Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if prov vis works with current version of d3 and lodash #734

Closed
flekschas opened this issue Sep 29, 2015 · 2 comments
Closed

Test if prov vis works with current version of d3 and lodash #734

flekschas opened this issue Sep 29, 2015 · 2 comments

Comments

@flekschas
Copy link
Member

In order to avoid using multiple or outdated versions of D3 and Lodash and have a consistent way of loading libraries (i.e. Bower) it'd be great to assess whether the prov vis works with the latest version of D3 (currently 3.5.6) and Lodash (currently 3.10.1)

@flekschas flekschas added this to the Next milestone Sep 29, 2015
@ngehlenborg ngehlenborg modified the milestones: Next, Gardner Oct 6, 2015
@ngehlenborg ngehlenborg modified the milestones: Gardner, Hadley Oct 19, 2015
@sluger
Copy link
Member

sluger commented Oct 20, 2015

This has been addressed in 5f94e1d.

@sluger sluger closed this as completed Oct 20, 2015
@flekschas
Copy link
Member Author

The old version (v3.4.11) of d3 is still being loaded on the dataset page, so the prov vis doesn't run with the latest version of d3 (v3.5.6)

https://github.com/parklab/refinery-platform/blob/develop/refinery/templates/core/data_set.html#L632

To reproduce:

  1. Go to https://refinery-dev.stemcellcommons.org/data_sets/20651210-9cf9-4c68-9ece-4301de84ad49/#/files/browse
  2. Open the developer tool bar
  3. Go to the console and type d3

This will output:

Object {version: "3.4.11", behavior: Object, event: null, ns: Object, time: Object…}

@flekschas flekschas reopened this Oct 21, 2015
@ngehlenborg ngehlenborg modified the milestones: Hadley, Ipswich Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants