Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated Angular API service #903

Closed
flekschas opened this issue Feb 23, 2016 · 2 comments
Closed

Duplicated Angular API service #903

flekschas opened this issue Feb 23, 2016 · 2 comments
Assignees
@flekschas
Labels
core enhancement ui

Comments

@flekschas
Copy link
Member

There are two services for fetching workflows which do exactly the same.

  1. ui/source/js/services.js
  2. ui/source/js/commons/services/workflows.js

I would remove the first one as the second one is more flexible (pulls the API path from the settings instead of hard-coding) and is located where all of the other common services is located.
@flekschas flekschas self-assigned this Feb 23, 2016
@flekschas flekschas added this to the Next milestone Feb 23, 2016
@flekschas flekschas mentioned this issue Feb 23, 2016
Closed
@flekschas
Copy link
Member Author

Coed Clean-up

@ngehlenborg ngehlenborg modified the milestone: Next Mar 8, 2016
@flekschas
Copy link
Member Author

Fixed in #1023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flekschas flekschas

Labels
core enhancement ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flekschas @ngehlenborg