Refactor post #154
Merged
Refactor post #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicinabox
commented
Dec 8, 2011
nicinabox
commented
- Extra post partial removed
- Add draft label UI
- Archive helper now only returns an li to be used in archive partial
added 3 commits
December 8, 2011 10:47
Now returns a list in an li instead of full markup
|
I don't get why the post partial was removed? Also if the functionality of blog_archive_list has changed or if the post partial is removed then this would in theory have to go into >= 2.0. |
|
It was confusing having 2 post partials when it wasn't clear what they actually did. I removed the extraneous partial that was called from the show view (and just moved that code into show) |
|
Merged, thanks! |
|
OK I talked to @joemsak, 1.8 it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.