More upgrades to move up to Rails 6 #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add puma and selenium-webdriver to Gemfile. Upgrade refinery version to 4.1.0 in gemspec Leave Rails at 6.0.0 until 6.1 problem with polymorphic is released (rails/rails#40879, includes a patch for ActiveRecord in the comments) Add rubocop fix for factory values Minor changes to allow for matching first of several page elements and how to click on them.
Add test gems/drivers as used for refinerycms Testing: moved 'making_an_inquiry' into spec/support/spec_helper updated spec/spec_helper to match refinerycms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add puma and selenium-webdriver to Gemfile.
Upgrade refinery version to 4.1.0 in gemspec
Leave Rails at 6.0.0 until 6.1 problem with polymorphic is released
(rails/rails#40879, includes a patch for
ActiveRecord in the comments)
Add rubocop fix for factory values
Change recieved to received
Minor changes to allow for matching first of several page elements and how to click on them.