Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

British Language Locale #26

Merged
merged 2 commits into from May 3, 2011
Merged

British Language Locale #26

merged 2 commits into from May 3, 2011

Conversation

tommoor
Copy link
Contributor

@tommoor tommoor commented Apr 19, 2011

Hey,

We have added a British locale for those of us that spell enquiries a little differently. In order for it to work correctly with other refinery engines which do not include the en-GB locale i18n fallbacks need to be enabled (included in pull request) and the following values in settings need to be set:

I18n Translation Current Locale - en-GB
I18n Translation Default Frontend Locale - en-GB

Cheers!
Tom.

@simi
Copy link
Member

simi commented Apr 21, 2011

-1 for this commit
It will override behavior in whole application.

It is better to add info about this into generator for example. But it will be still annoying.

Best way probably will be to use Fallbacks - http://stackoverflow.com/questions/2324398/fall-back-to-default-language-if-translation-missing/2325078#2325078 and that should be in RefineryCMS core ( https://github.com/resolve/refinerycms/tree/master/config/initializers ), not in engine.

But I'm still not sure if it is good to override Rails 3 default behaviour.

@parndt
Copy link
Member

parndt commented Apr 29, 2011

Yeah, the initializer would override the entire application which we can't do in an engine..

@parndt
Copy link
Member

parndt commented May 3, 2011

Configured fallbacks in refinerycms-i18n

@parndt parndt merged commit 5ea479d into refinery:master May 3, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants