Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download button for saving contours in the profile uncertainty tab as columnar data #176

Closed
Tracked by #170
purnimab opened this issue Apr 11, 2024 · 5 comments

Comments

@purnimab
Copy link
Contributor

purnimab commented Apr 11, 2024

Current "Download CSV" button downloads only the first outputted contour file (e.g. rho, but not irho or rhoM, for only the first profile)

@purnimab purnimab mentioned this issue Apr 11, 2024
14 tasks
@bmaranville
Copy link
Member

yikes!

@bmaranville
Copy link
Member

bmaranville commented Apr 12, 2024

I'm not able to reproduce the problem - if I run it on a FitProblem with 2 models I get something like this:

"M0 z","M0 rho (68 lower)","M0 rho (68 upper)","M0 rho (95 lower)","M0 rho (95 upper)","M0 irho (68 lower)","M0 irho (68 upper)","M0 irho (95 lower)","M0 irho (95 upper)","M0 rhonM (68 lower)","M0 rhonM (68 upper)","M0 rhonM (95 lower)","M0 rhonM (95 upper)","M0 thetaM (68 lower)","M0 thetaM (68 upper)","M0 thetaM (95 lower)","M0 thetaM (95 upper)","M1 z","M1 rho (68 lower)","M1 rho (68 upper)","M1 rho (95 lower)","M1 rho (95 upper)","M1 irho (68 lower)","M1 irho (68 upper)","M1 irho (95 lower)","M1 irho (95 upper)","M1 rhonM (68 lower)","M1 rhonM (68 upper)","M1 rhonM (95 lower)","M1 rhonM (95 upper)","M1 thetaM (68 lower)","M1 thetaM (68 upper)","M1 thetaM (95 lower)","M1 thetaM (95 upper)"
-483.736,4.64920,4.65284,4.64953,4.65174,0.600167,2.06121,0.751717,1.63305,0.0000187382,0.00221306,0.000297606,0.00128383,269.514,269.810,269.514,269.746,-483.736,4.64920,4.65284,4.64953,4.65174,0.600167,2.06121,0.751717,1.63305,0.0000546714,0.00203070,0.000235010,0.00117346,269.514,269.780,269.514,269.711
-475.750,4.64920,4.65284,4.64953,4.65174,0.600167,2.06121,0.751717,1.63305,0.0000282566,0.00221306,0.000297606,0.00128383,269.513,269.810,269.514,269.733,-475.750,4.64920,4.65284,4.64953,4.65174,0.600167,2.06121,0.751717,1.63305,0.0000546714,0.00203070,0.000235010,0.00117346,269.513,269.780,269.514,269.707
-467.763,4.64920,4.65284,4.64950,4.65174,0.600167,2.06121,0.751717,1.63305,0.0000282566,0.00221306,0.000297606,0.00128383,269.356,269.810,269.514,269.733,-467.763,4.64920,4.65284,4.64950,4.65174,0.600167,2.06121,0.751717,1.63305,0.0000546714,0.00226157,0.000235010,0.00131939,269.356,269.780,269.514,269.707

Can you give some more information about your fitProblem? If possible, can you attach a zip file with the data + model file here? Also, could you paste the first few lines of your problematic CSV output?

@purnimab
Copy link
Contributor Author

purnimab commented Apr 12, 2024 via email

@bmaranville
Copy link
Member

It looks like it's happening because the models have the same name ("Stack" for both). We should probably not use a dict keyed on the model name for passing around the profile data, because non-unique model names happen all the time.

bmaranville added a commit that referenced this issue Apr 12, 2024
@bmaranville
Copy link
Member

Tested with original model names: output is as follows

"Stack z","Stack rho (68 lower)","Stack rho (68 upper)","Stack rho (95 lower)","Stack rho (95 upper)","Stack rhoM (68 lower)","Stack rhoM (68 upper)","Stack rhoM (95 lower)","Stack rhoM (95 upper)","Stack thetaM (68 lower)","Stack thetaM (68 upper)","Stack thetaM (95 lower)","Stack thetaM (95 upper)","Stack 1 z","Stack 1 rho (68 lower)","Stack 1 rho (68 upper)","Stack 1 rho (95 lower)","Stack 1 rho (95 upper)","Stack 2 z","Stack 2 rho (68 lower)","Stack 2 rho (68 upper)","Stack 2 rho (95 lower)","Stack 2 rho (95 upper)","Stack 2 rhoM (68 lower)","Stack 2 rhoM (68 upper)","Stack 2 rhoM (95 lower)","Stack 2 rhoM (95 upper)","Stack 2 thetaM (68 lower)","Stack 2 thetaM (68 upper)","Stack 2 thetaM (95 lower)","Stack 2 thetaM (95 upper)","Stack 3 z","Stack 3 rho (68 lower)","Stack 3 rho (68 upper)","Stack 3 rho (95 lower)","Stack 3 rho (95 upper)","Stack 4 z","Stack 4 rho (68 lower)","Stack 4 rho (68 upper)","Stack 4 rho (95 lower)","Stack 4 rho (95 upper)","Stack 4 rhoM (68 lower)","Stack 4 rhoM (68 upper)","Stack 4 rhoM (95 lower)","Stack 4 rhoM (95 upper)","Stack 4 thetaM (68 lower)","Stack 4 thetaM (68 upper)","Stack 4 thetaM (95 lower)","Stack 4 thetaM (95 upper)","Stack 5 z","Stack 5 rho (68 lower)","Stack 5 rho (68 upper)","Stack 5 rho (95 lower)","Stack 5 rho (95 upper)"
-13.7320,5.66134,5.66151,5.66143,5.66149,0.00000,0.00000,0.00000,0.00000,270.000,270.000,270.000,270.000,-13.7320,5.66434,5.66434,5.66434,5.66434,-13.7320,5.66134,5.66151,5.66143,5.66149,0.00000,0.00000,0.00000,0.00000,270.000,270.000,270.000,270.000,-13.7320,5.66434,5.66434,5.66434,5.66434,-13.7320,5.66134,5.66151,5.66143,5.66149,0.00000,0.00000,0.00000,0.00000,270.000,270.000,270.000,270.000,-13.7320,5.66434,5.66434,5.66434,5.66434
-12.5802,5.64792,5.64932,5.64835,5.64885,0.00000,0.00000,0.00000,0.00000,270.000,270.000,270.000,270.000,-13.5858,5.66344,5.66354,5.66348,5.66350,-12.5802,5.64792,5.64932,5.64835,5.64885,0.00000,0.00000,0.00000,0.00000,270.000,270.000,270.000,270.000,-13.5858,5.66344,5.66354,5.66348,5.66350,-12.5802,5.64792,5.64932,5.64835,5.64885,0.00000,0.00000,0.00000,0.00000,270.000,270.000,270.000,270.000,-13.5858,5.66344,5.66354,5.66348,5.66350
-11.4285,5.62039,5.62624,5.62203,5.62384,0.00000,0.00000,0.00000,0.00000,270.000,270.000,270.000,270.000,-13.4395,5.66246,5.66268,5.66254,5.66259,-11.4285,5.62039,5.62624,5.62203,5.62384,0.00000,0.00000,0.00000,0.00000,270.000,270.000,270.000,270.000,-13.4395,5.66246,5.66268,5.66254,5.66259,-11.4285,5.62039,5.62624,5.62203,5.62384,0.00000,0.00000,0.00000,0.00000,270.000,270.000,270.000,270.000,-13.4395,5.66246,5.66268,5.66254,5.66259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants