Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #103 / PR #105 / Patch #105 #106

Merged
merged 2 commits into from
Aug 5, 2016

Conversation

matthiasbalke
Copy link
Member

@matthiasbalke matthiasbalke commented Aug 4, 2016

This PR combines PR #103, PR #105 and the patch file of PR #105.

PR #103

  • refactored the package structure of each slice to have "domain" and "rest" package
  • added spring-hateoas and refactored all Resources to extend ResourceSupport.
  • replaced mappers with ResourceAssemblers
  • made WidgetConfig a sub-resource of Dashboard
  • added basic unit tests for all RestController methods
  • added Helper classes to work with JSON and to provide ResultMatchers to assert Resources

PR #105

  • added a patch for new API to make client work (must be appplied after added support for HATEOAS #103)
    • fixed some tslint rules
    • fixed createWidget.sh
    • using HalJson links now (only one entry point left)

@matthiasbalke matthiasbalke added this to the 0.2.0 milestone Aug 4, 2016
@matthiasbalke matthiasbalke self-assigned this Aug 4, 2016

import com.github.reflectoring.infiniboard.packrat.source.SourceConfig;

public class WidgetConfigResource extends ResourceSupport {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Override this superclass' "equals" method. rule
MINOR Document this public class. rule

@matthiasbalke
Copy link
Member Author

SonarQube analysis reported 41 issues

  • MAJOR 7 major
  • MINOR 34 minor

Watch the comments in this conversation to review them.

9 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR Dashboard.java#L8: Document this public class. rule
  2. MINOR Dashboard.java#L16: Document this public constructor. rule
  3. MINOR DashboardRepository.java#L19: Document this public constructor. rule
  4. MINOR WidgetConfigService.java#L15: Document this public class. rule
  5. MINOR WidgetConfigService.java#L22: Document this public constructor. rule
  6. MINOR WidgetConfigService.java#L28: Document this public method. rule
  7. MINOR WidgetConfigService.java#L32: Document this public method. rule
  8. MINOR WidgetConfigService.java#L37: Document this public method. rule
  9. MINOR WidgetConfigService.java#L41: Document this public method. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants