Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update requriements.txt and test for issue 55 #59

Merged

Conversation

milochen0418
Copy link
Contributor

@milochen0418 milochen0418 commented Apr 29, 2023

According to the issue #55
Update requriement.txt for latest version pynecone==0.1.28 on PyPI

  • chatroom
  • clock
  • counter
  • crm
  • dalle
  • fragments
  • gpt
  • nba
  • quiz
  • sales
  • snakegame
  • todo
  • translator
  • traversal
  • twitter

The box with the check icon is the code we can run on pynecone==0.1.28

Notes

`1. Note of sales's testing
The code is working but just with a little issue, and we can fix it in future PR.

2. Note of todo's testing
The code is working but just with a little issue, and we can fix it in future PR.

Environment suggestion

If you want to run all example code, it must satisfy the following condition.

node: 16.6.0
bun: 5.9

On my computer, my Python version is 3.11.3.
If some examples here cannot run well, you can use python 3.11.3

The related issues that have been close from these PR updating

@milochen0418 milochen0418 changed the title update requriements.txt and test for issue 55 , partially update requriements.txt and test for issue 55 Apr 30, 2023
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these!

crm/crm/components/crm.py Outdated Show resolved Hide resolved
@milochen0418
Copy link
Contributor Author

Thanks for updating these!

Thanks !
pynecone-examples is very important for application developer who touch pynecone first time.

many people start to touch pynecone and first question is why example cannot work well.

So, I try my best to make the all examples work for the lastest release 0.1.27. Because I know more and more people need this.

@milochen0418 milochen0418 requested a review from masenf May 1, 2023 18:59
@Alek99
Copy link
Member

Alek99 commented May 2, 2023

Nice job! Thanks @milochen0418 really appreciate this!!

@Alek99 Alek99 self-requested a review May 2, 2023 04:43
@Alek99
Copy link
Member

Alek99 commented May 2, 2023

New version is released

@milochen0418
Copy link
Contributor Author

Thanks @Alek99 ~~ :D I'm testing all example code to make sure every example can fit pynecone==0.1.28 now

@milochen0418
Copy link
Contributor Author

Hi @Alek99 @masenf ,
the examples have been updated to fit pynecone==0.1.28
Please review it.

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think we should take this soon, so that folks picking up the project don't get tripped up on broken examples.

Copy link
Member

@Alek99 Alek99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice look good, thanks!

@Alek99 Alek99 merged commit 5d35863 into reflex-dev:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants