add pr_id in case the pr title is changed

reflex-dev · Mar 20, 2024 · 11aa13d · 11aa13d
1 parent 5faa517
commit 11aa13d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml
@@ -123,4 +123,4 @@ jobs:
           --python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}" 
           --benchmark-json "${{ env.OUTPUT_FILE }}" --pr-title "${{ github.event.pull_request.title }}"
           --db-url "${{ env.DATABASE_URL }}" --branch-name "${{ github.head_ref || github.ref_name }}"
-          --event-type "${{ github.event_name }}" --actor "${{ github.actor }}"
+          --event-type "${{ github.event_name }}" --actor "${{ github.actor }}" --pr-id "${{ github.event.pull_request.id }}"
diff --git a/scripts/simple_app_benchmark_upload.py b/scripts/simple_app_benchmark_upload.py
@@ -59,6 +59,7 @@ def insert_benchmarking_data(
     branch_name: str,
     event_type: str,
     actor: str,
+    pr_id: str,
 ):
     """Insert the benchmarking data into the database.
 
@@ -72,6 +73,7 @@ def insert_benchmarking_data(
         branch_name: The name of the branch.
         event_type: Type of github event(push, pull request, etc)
         actor: Username of the user that triggered the run.
+        pr_id: Id of the PR.
     """
     # Serialize the JSON data
     simple_app_performance_json = json.dumps(performance_data)
@@ -82,8 +84,8 @@ def insert_benchmarking_data(
     # Connect to the database and insert the data
     with psycopg2.connect(db_connection_url) as conn, conn.cursor() as cursor:
         insert_query = """
-            INSERT INTO simple_app_benchmarks (os, python_version, commit_sha, time, pr_title, branch_name, event_type, actor, performance)
-            VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s);
+            INSERT INTO simple_app_benchmarks (os, python_version, commit_sha, time, pr_title, branch_name, event_type, actor, performance, pr_id)
+            VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s);
             """
         cursor.execute(
             insert_query,
@@ -97,6 +99,7 @@ def insert_benchmarking_data(
                 event_type,
                 actor,
                 simple_app_performance_json,
+                pr_id
             ),
         )
         # Commit the transaction
@@ -145,6 +148,11 @@ def main():
         help="Username of the user that triggered the run.",
         required=True,
     )
+    parser.add_argument(
+        "--pr-id",
+        help="ID of the PR.",
+        required=True,
+    )
     args = parser.parse_args()
 
     # Get the results of pytest benchmarks
@@ -160,6 +168,7 @@ def main():
         branch_name=args.branch_name,
         event_type=args.event_type,
         actor=args.actor,
+        pr_id=args.pr_id
     )