Skip to content

Commit

Permalink
make PR title optional since push event or PR merge will not have the…
Browse files Browse the repository at this point in the history
… title
  • Loading branch information
martinxu9 committed Mar 20, 2024
1 parent 8ea75cb commit c74bb72
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions scripts/simple_app_benchmark_upload.py
Expand Up @@ -104,11 +104,7 @@ def insert_benchmarking_data(


def main():
"""Runs the benchmarks and inserts the results.
Raises:
ValueError: If the PR title is not provided.
"""
"""Runs the benchmarks and inserts the results."""
# Get the commit SHA and JSON directory from the command line arguments
parser = argparse.ArgumentParser(description="Run benchmarks and process results.")
parser.add_argument(
Expand Down Expand Up @@ -150,9 +146,8 @@ def main():
)
args = parser.parse_args()

pr_title = args.pr_title or os.getenv("PR_TITLE")
if not pr_title:
raise ValueError("PR title is required")
# Get the PR title from env or the args. For the PR merge or push event, there is no PR title, leaving it empty.
pr_title = args.pr_title or os.getenv("PR_TITLE", "")

# Get the results of pytest benchmarks
cleaned_benchmark_results = extract_stats_from_json(args.benchmark_json)
Expand Down

0 comments on commit c74bb72

Please sign in to comment.