Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowed flex to accept lists #1503

Closed
wants to merge 1 commit into from
Closed

Conversation

ckavanagh21
Copy link

changed "wrap" and "direction" to allow lists instead of just strings
closes #1494
closes #1495

I also wanted to point out that one of the tests is failing, but I'm unsure if it's relevant to my changes. It has to do with a syntax error in a completely different file. Here's the output:
=============================================== short test summary info =============================================== FAILED tests/test_model.py::test_automigration - sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) near "DROP": syntax error ============================================ 1 failed, 529 passed in 6.52s ============================================

Not sure if that's relevant, but I wanted to point it out.

All Submissions:

  • [ x] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [ x] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • [ x] Does your submission pass the tests?
  • [ x] Have you linted your code locally prior to submission?

changed "wrap" and "direction" to allow lists instead of just strings
@masenf
Copy link
Collaborator

masenf commented Aug 2, 2023

"DROP": syntax error

This is a result of running python built against sqlite < 3.35 where ALTER TABLE ... DROP COLUMN support was added. See discussion in #1356. Safe to ignore.

@masenf
Copy link
Collaborator

masenf commented Aug 21, 2023

fixed via #1553

@masenf masenf closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flex wrap does not support lists Flex direction doesnt take list as value
2 participants