New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rx.link href prop and Var.to_string type #1600

Merged

picklelo merged 2 commits into main from nikhil/vars

Aug 16, 2023

Contributor

picklelo commented Aug 16, 2023

Update rx.link to read the href prop from the **props kwarg. Before we were hitting some type checking issues because we specified the type had to be Var[str].
Update the type for var operations to_string as well as the bool operators

masenf approved these changes

View reviewed changes

picklelo added 2 commits

August 16, 2023 11:29


          Fix rx.link href prop


          Update bool var types

89976a9

picklelo force-pushed the nikhil/vars branch from 720df69 to 89976a9 Compare

August 16, 2023 18:29

picklelo merged commit 00714c6 into main

34 checks passed

picklelo deleted the nikhil/vars branch

August 16, 2023 18:41

masenf mentioned this pull request

Update link.py #1488

Closed

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment