Add option to specify port #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picklelo
requested changes
Dec 30, 2022
pynecone/utils.py
Outdated
| @@ -533,6 +537,13 @@ def get_num_workers() -> int: | |||
| return (os.cpu_count() or 1) * 2 + 1 | |||
|
|
|||
|
|
|||
| def get_api_port(): | |||
There was a problem hiding this comment.
This needs a return type annotation -> int as well as a docstring to make the build happy.
The docstring can just be
"""Get the API port.
Returns:
The API port.
"""
pynecone/utils.py
Outdated
| def get_api_port(): | ||
| result = urlparse(get_config().api_url) | ||
| if result.port is None: | ||
| return urlparse(constants.API_URL).port |
There was a problem hiding this comment.
You may need to add an assert here for Pyright
port = urlparse(...)
assert port is not None
return port
pynecone/utils.py
Outdated
| @@ -559,6 +571,8 @@ def run_backend_prod( | |||
| """ | |||
| num_workers = get_num_workers() | |||
| command = constants.RUN_BACKEND_PROD + [ | |||
| "--bind", | |||
| "0.0.0.0:%s"%get_api_port(), | |||
There was a problem hiding this comment.
Can we use an f-string here for consistency with the rest of the code?
f"0.0.0.0:{get_api_port()}"
|
Yes thanks for implementing this feature definitely needed! 🙂 |
picklelo
approved these changes
Dec 30, 2022
Done. @picklelo |
ACucos1
pushed a commit
to ACucos1/rd-pynecone
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #157