Reduce Syntax highlighter footprint #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahAhianyo
changed the title
masenf
requested changes
Oct 31, 2023
ElijahAhianyo
force-pushed
the
elijah/reduce-syntax-highlighter-footprint
branch
from
e27605e
to
42397dc
Compare
|
Is this ready for review? |
yes it is |
masenf
previously approved these changes
Nov 8, 2023
picklelo
reviewed
Nov 10, 2023
|
|
||
| # The theme to use ("light" or "dark"). | ||
| theme: Var[LiteralTheme] | ||
| theme: Var[LiteralCodeBlockTheme] = "prism" # type: ignore |
There was a problem hiding this comment.
Should we update the comment for this now?
There was a problem hiding this comment.
We could do that, however, I expected this issue https://linear.app/reflex-dev/issue/REF-1078/in-props-section-add-a-section-for-valid-literals to handle displaying the valid prop values from the literals.
picklelo
requested changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running without PR(before):
Running with PR(after):
fixes #1997