Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new pyi script #2041

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Apply new pyi script #2041

merged 6 commits into from
Nov 16, 2023

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Oct 26, 2023 •
edited
Loading

For all components except including plotly, need to resolve resolution conflict.

@Alek99 Alek99 self-requested a review October 26, 2023 19:12
Alek99
Alek99 requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@Alek99 Alek99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not comfortable with this large of a pr so close to the release and calhacks, lets just add the new pyi for the data editor and keep the old pyi for the other files

masenf
masenf requested changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but looks big. I can understand the hesitation to bring this in this close to calhacks.

One other fixup is needed from my previous PR:

reflex/components/base/body.pyi Outdated Show resolved Hide resolved
@Lendemor
Copy link
Collaborator Author

I'm not comfortable with this large of a pr so close to the release and calhacks, lets just add the new pyi for the data editor and keep the old pyi for the other files

Then I'll add it on the datatable PR and we can merge this one after the release.

masenf
masenf approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@picklelo picklelo merged commit ddb1f81 into main Nov 16, 2023
45 checks passed
Alek99 pushed a commit that referenced this pull request Nov 20, 2023
@Lendemor
Apply new pyi script (#2041)
48c6ac2
@masenf masenf deleted the lendemor/apply_new_pyi_script branch December 6, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

@Alek99 Alek99 Awaiting requested review from Alek99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lendemor @masenf @Alek99 @picklelo