Expose gunicorn_worker_class via Config #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than plumbing through every possible uvicorn parameter that users might need in production, expose the gunicorn_worker_class in the config, which allows downstream code to completely control the worker configuration as needed. Most users will not need to set this knob, but the moment one needs to tweak websocket protocol flags, timeout values, or the wealth of uvicorn config knobs for tweaking, then it's straightforward to override the worker class and apply these behavior changes. Fix #2070
Lendemor
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than plumbing through every possible uvicorn parameter that users might need in production, expose the gunicorn_worker_class in the config, which allows downstream code to completely control the worker configuration as needed.
Most users will not need to set this knob, but the moment one needs to tweak websocket protocol flags, timeout values, or the wealth of uvicorn config knobs for tweaking, then it's straightforward to override the worker class and apply these behavior changes.
Fix #2070