New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF-1050/Investigate Windows Hot reload #2106
Conversation
35c0abe
to
3be5099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
It doesn't seem significantly faster on my windows VM. Still installs tailwind every time... |
also seems like this turns up the log level of npm by default? my terminal is displaying a lot more output now |
I see, when you look at the npm logs for tailwind, does the cache get revalidated every time? |
not sure how to tell... |
I added this as a result of this issue(#2115) where the installation fails but theres not much details on why. Probably there's a better way to handle this, Maybe move that a log level up(Error instead of debug)? |
usually you'd see this in the logs when its revalidated:
Also just to get a sense of how little of a difference it makes for you, what are the time differences(or numbers) when you run with the |
When i run with npm_prefer_offline, it takes about 12 seconds from when i hit save to when the npm output stops scrolling. When i run without npm_prefer_offline, it's about the same, 13 seconds from when i hit save. As for the tailwind thing, i think my output is getting screwed up on windows, because i see this when it mentions tailwind npm info ok
⠋ Installing tailwindnpm info using npm@9.6.7
npm info using node@v18.17.0
npm http fetch GET 200 https://registry.npmjs.org/tailwindcss 673ms (cache updated)
⠋ Installing tailwind[##################] / reify:@next/swc-darwin-arm64: timing reifyNode:node_modules/@next/swc-darwinnpm http fetch POST 200 https://registry.npmjs.org/-/npm/v1/security/advisories/bulk 130ms
⠙ Installing tailwind[##################] \ reify:@next/swc-darwin-arm64: http fetch POST 200 https://registry.npmjs.org |
I see this is approved, but may have some issues. What is the best way to go about testing this |
Moving the performance tests to a sub PR(#2136) as I need to do a bit more investigation on why this behaves differently on other windows |
This PR fixes a peer dependency resolution error by the postcss lib causing a relock of the
package-lock.json
file.