Prompt for template on reflex init #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I haven't included yet - if the user specifies a template up front we should skip this check. Currently if they do |
masenf
reviewed
Nov 2, 2023
picklelo
force-pushed
the
nikhil/template-cli
branch
from
ab1c9ca
to
2c5b120
Compare
masenf
reviewed
Nov 3, 2023
masenf
previously approved these changes
Nov 3, 2023
docker-example/Dockerfile
Outdated
| @@ -17,7 +17,7 @@ RUN python3.11 -m venv $VIRTUAL_ENV | |||
| RUN pip install -r requirements.txt | |||
|
|
|||
| # Deploy templates and prepare app | |||
| RUN reflex init | |||
| RUN reflex init --template blank | |||
There was a problem hiding this comment.
we actually probably don't need this in the dockerfile, because the app should already exist when the container is being built... not sure if it hurts anything though.
There was a problem hiding this comment.
Good point - I'll remove this
masenf
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask the user to specify a template interactively on the first
reflex init.