Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form: only pass handleSubmit when on_submit is defined #2162

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Nov 13, 2023

No description provided.

Make it easier for downstream components to manipulate the `Tag` object before
`render` converts it into a dict.
Avoid modifying the Component itself during the rendering call.
Passing duplicate keyword arguments to a function is not supported, so instead
update the props as a dict first, then pass the final set of props to the tag.
@picklelo picklelo merged commit f3929f4 into main Nov 14, 2023
45 checks passed
@masenf masenf deleted the masenf/form-submit-fixup branch December 6, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants