[REF-1158] Move chakra-only deps to chakra lib #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove chakra workarounds from other parts of the framework.
masenf
force-pushed
the
masenf/chakra-duck
branch
from
7e3ecc0
to
aca4121
Compare
I think this was originally a perf optimization... how big is the impact for the possibility of introduced bugs?
Lendemor
reviewed
Nov 22, 2023
reflex/components/libs/chakra.py
Outdated
There was a problem hiding this comment.
Could we move this to a chakra/base.py or libs/chakra/base.py ?
Though I'm not sure we actually need the libs folder.
picklelo
previously approved these changes
Nov 28, 2023
| from reflex.utils.imports import ImportDict, ImportVar | ||
|
|
||
| # Imports to be included in every Reflex app. | ||
| DEFAULT_IMPORTS: ImportDict = { |
Allow DebounceInput to work with both chakra and radix UI components.
picklelo
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove chakra workarounds from other parts of the framework.
This allows for a completely chakra-free and radix-free experience using basic elements and tailwind css.
Module size top 10 with chakra and radix components used
Module size top 10 without component lib:
Next itself is still huge, but thankfully this compiles down to a reasonable size for the given functionality!