Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add/subtract in moment #2212

Merged
merged 3 commits into from Nov 22, 2023
Merged

add/subtract in moment #2212

merged 3 commits into from Nov 22, 2023

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Nov 22, 2023 •
edited

Implement add/subtract feature of moment.

(needed for the docs PR : reflex-dev/reflex-web#323)

@Lendemor Lendemor changed the title add/subtract in moment plus small fixes add/subtract in moment Nov 22, 2023
masenf
masenf approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, and is simple to use.

Consider adding a test case.

@picklelo picklelo merged commit d61b83f into main Nov 22, 2023
45 checks passed
@masenf masenf deleted the lendemor/add_and_substract_prop_moment branch December 6, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lendemor @masenf @picklelo