New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF-1417] Convert underscore-prefixed style props to pseudo selector #2266
Conversation
a290242
to
b8c2084
Compare
619c287
to
b7678ab
Compare
Is this ready for review? I'll try it out |
Use emotion CSS-in-JS for default components. Convert underscore-prefixed style props, like `_hover` and `_focus` to emotion compatible self-referential pseudo selectors like `&:hover` and `&:focus`.
Adding integration coverage
b7678ab
to
cd08b7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, solves 3 issues in one PR
# The wrapped backtick is used to identify the Var for interpolation. | ||
return f"`{str(new_var)}`", new_var._var_data | ||
|
||
return style_item, None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If style_item
is not a str
would the type signature still be correct here? Should it be str(style_item
)?
Use emotion CSS-in-JS for default components.
Convert underscore-prefixed style props, like
_hover
and_focus
to emotion compatible self-referential pseudo selectors like&:hover
and&:focus
.Test cases
Keys
Values
Extension precedence
style={}
Types of Test
Sample Code