Refactor chakra components into separate folder #2315
Conversation
reflex/components/chakra/chakra.py
Outdated
There was a problem hiding this comment.
To keep with how we do it for radix, maybe this chakra.py file need to be renamed base.py since it's already inside the chakra folder anyway
reflex/components/chakra/__init__.py
Outdated
| from .media.image import Image | ||
|
|
||
| image = Image.create | ||
| from .chakra import * |
There was a problem hiding this comment.
from .base import * if we actually rename chakra.py as mentioned in other comment.
There was a problem hiding this comment.
Debounce is not chakra specific, it can probably go to core or it's own folder.
There was a problem hiding this comment.
we actually use this for the radix textfield as well
There was a problem hiding this comment.
since Password doesn't actually exist in Chakra, this should probably become a high level component only, that specialize an input with type="password"
There was a problem hiding this comment.
Agreed, I think these ones are tied to the Chakra Input component, maybe we can leave it for now and abstract it later.
reflex/app.pyi
Outdated
| @@ -12,7 +12,7 @@ from reflex.components.component import ( | |||
| Component as Component, | |||
| ComponentStyle as ComponentStyle, | |||
| ) | |||
| from reflex.components.layout.fragment import Fragment as Fragment | |||
| from reflex.components.chakra.layout.fragment import Fragment as Fragment | |||
There was a problem hiding this comment.
| from reflex.components.chakra.layout.fragment import Fragment as Fragment | |
| from reflex.components.base.fragment import Fragment as Fragment |
i thought this got moved to base
There was a problem hiding this comment.
we actually use this for the radix textfield as well
There was a problem hiding this comment.
why no pyi file for this component?
There was a problem hiding this comment.
I'm not sure, I ran the generator
There was a problem hiding this comment.
multiselect.py is black-listed in the generator, probably a remnant of when it was broken ?
There was a problem hiding this comment.
We can bring it back now I suppose
picklelo
force-pushed
the
nikhil/refactor-components
branch
from
b4bcf66
to
e664fd6
Compare
| from .gridjs import * | ||
| from .markdown import * | ||
| from .moment import * | ||
| from .next import NextLink, next_link |
There was a problem hiding this comment.
With this change do we still have access to the namespaced rx.next.image and rx.next.video ?
This change moves most of the core components into the
reflex/components/chakranamespace, in order to prepare for the switch to the Radix components.All imports for end-users should work exactly as is, this is just an internal restructuring.