Add reflex init app name validator, prevent import failure during reflex run #2336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Type of change
New Feature Submission:
Changes To Core Features:
Issue: improper app directory name passed during reflex init will cause reflex run to fail, if the name is not according to python package naming conventions.
Run the below command to recreate the issue,
reflex init --name="123" --template="sidebar"
and try running
reflex run
.We get the following error.
This issue can also occur if
reflex init
is run inside a folder with similar improper app directory naming.I've refactored get_default_app_name() of reflex init, and added a regex validator to check the app_name passed to the function, to ensure proper directory naming. Else it displays a console error, with proper message.