[REF-1705] Do not overwrite Var attributes during format #2421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the values given to
format_cond
are already Var, do NOT mutate the attributes since subsequent usages of the same Var may be adversely affected.Add test cases for
is_prop=True
path offormat_cond
, where this bug was hiding.Here is a repro case
Check the output, the
State.val
repr should NOT change just because the value was used in anrx.cond
.