Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto enable /_upload endpoint only if Upload component is used #2430

Merged
merged 10 commits into from Jan 23, 2024
Merged

auto enable /_upload endpoint only if Upload component is used #2430

merged 10 commits into from Jan 23, 2024

Conversation

benedikt-bartscher
Copy link
Contributor

@benedikt-bartscher benedikt-bartscher commented Jan 21, 2024 •
edited

https://github.com/orgs/reflex-dev/discussions/2415

This also changes the pyi generator to ignore ClassVars in the Component.create method and do not delete ClassVars in the class attributes

@benedikt-bartscher benedikt-bartscher marked this pull request as draft January 21, 2024 23:11
@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review January 21, 2024 23:30
masenf
masenf requested changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and helping meet user needs.

A couple of suggestions:

reflex/components/core/upload.py Outdated Show resolved Hide resolved
reflex/components/core/upload.py Outdated Show resolved Hide resolved
masenf
masenf approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for wrangling the pyi_generator, that script can be a pain sometimes.

@picklelo picklelo merged commit 0b1b8ee into reflex-dev:main Jan 23, 2024
42 of 43 checks passed
Alek99 pushed a commit that referenced this pull request Jan 24, 2024
@benedikt-bartscher
auto enable /_upload endpoint only if Upload component is used (#2430)
27f4720
@masenf masenf mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benedikt-bartscher @masenf @picklelo