Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use multiprocessing to speed up pyi generation #2453

Merged
merged 1 commit into from Jan 25, 2024
Merged

use multiprocessing to speed up pyi generation #2453

merged 1 commit into from Jan 25, 2024

Conversation

benedikt-bartscher
Copy link
Contributor 

# main
python scripts/pyi_generator.py  23,71s user 2,06s system 107% cpu 23,960 total

# this PR
python scripts/pyi_generator.py  79,24s user 94,34s system 2111% cpu 8,220 total

masenf
masenf approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, fast is good.

@benedikt-bartscher benedikt-bartscher mentioned this pull request Jan 25, 2024
Closed
@Alek99
Copy link
Contributor

Alek99 commented Jan 25, 2024

Nice!

@Alek99 Alek99 merged commit 4219a78 into reflex-dev:main Jan 25, 2024
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benedikt-bartscher @Alek99 @masenf