New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs validate parent is proper tab container #2463
Conversation
closes #2173 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why using _valid_children
didn't work for this case?
The requirement here is: when user create a component of rx.SomeComponent(rx.TabList) we need to report error.
Here are two ideas:
|
What about making Okay wait, that's what you already said... let me think about it a bit more. |
@masenf Any follow-ups? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition - this will be useful for our new radix components as well which have nested components like this.
All Submissions:
Type of change
Please delete options that are not relevant.
After these steps, you're ready to open a pull request.