[REF-1815] Radix themes: replace color_scheme with color in get_fields
#2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that the components never emit an actual `color_scheme`
prop to the generated code. Instead of treating the `color` prop swap in
`create` as a CSS prop, it will instead will emit `color={...}` as a direct
prop. Handling `color` as a style prop already occurs explicitly in `create`.
REF-1815
picklelo
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the components never emit an actual
color_schemeprop to the generated code. Instead of treating thecolorprop swap increateas a CSS prop, it will instead will emitcolor={...}as a direct prop. Handlingcoloras a style prop already occurs explicitly increate.