[0.4.0] Namespace the Drawer primitive subcomponents #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid hacky and incorrect parsing of `__qualname__`.
picklelo
approved these changes
Jan 31, 2024
| drawer_close = DrawerClose.create | ||
| drawer_title = DrawerTitle.create | ||
| drawer_description = DrawerDescription.create | ||
| class Drawer(SimpleNamespace): |
There was a problem hiding this comment.
I think we can make a subclass of SimpleNamespace such that we can define these like:
class Drawer(NamespaceSubclass):
root = DrawerRoot
trigger = DrawerTrigger
...There was a problem hiding this comment.
that would break static analysis and autocomplete i think. i tried making a fancy class first
There was a problem hiding this comment.
to be clear, i'm not opposed to the idea per-se, but it might be trickier to get the typing right and would definitely need some help from pyi_generator.
i'd prefer to go with the simpler, expliciter route for now, but after we get this all out the door, i'm not opposed to a refactor or cleanup of the namespace classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
Drawercomponent uses aSimpleNamespacelike the other primitives.