Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/113 follow up #252

Merged
merged 6 commits into from Jan 13, 2023
Merged

Conversation

ElijahAhianyo
Copy link
Collaborator

@ElijahAhianyo ElijahAhianyo commented Jan 13, 2023

113-Pynecone-support-for-windows-symlink-follow-up

  • Removed symlink logic for non-windows
  • Added Test case for test setting up frontend logic

- [x] Removed symlink logic for non windows
- [x] Removed symlink logic for non windows
- [x] Added Test case to test setting up frontend logic
@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review January 13, 2023 15:44
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@picklelo picklelo merged commit c893635 into reflex-dev:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants