Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 404 custom page handling #265

Merged
merged 1 commit into from Jan 15, 2023
Merged

add 404 custom page handling #265

merged 1 commit into from Jan 15, 2023

Conversation

Lendemor
Copy link
Collaborator

Closes #234

Allow to add a default 404 page:

Will add a catchall route that match all undefined route, and display the given page.

picklelo
picklelo reviewed Jan 15, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just an idea to possibly simplify the API we expose

pynecone/app.py Show resolved Hide resolved
picklelo
picklelo approved these changes Jan 15, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@picklelo picklelo merged commit 8858754 into reflex-dev:main Jan 15, 2023
ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
@Lendemor @ACucos1
Add 404 custom page handling (reflex-dev#265)
85f0c33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create custom 404 page
2 participants
@Lendemor @picklelo