[REF-1993] link: respect is_external prop and other attributes on A tag
#2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing all props to NextLink by default, only pass props that NextLink understands, placing the remaining props on the Radix link Add a test case to avoid regression of `is_external` behavior.
Because Link is often rendered with NextLink as_child, and NextLink breaks if the href is stateful outside of a Link, ensure that any stateful child of Link gets memoized together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing all props to NextLink by default, only pass props that NextLink understands, placing the remaining props on the Radix link
Add a test case to avoid regression of
is_externalbehavior.Fix #2648