Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix telemetry for init event #2736

Merged
merged 1 commit into from Feb 27, 2024
Merged

fix telemetry for init event #2736

merged 1 commit into from Feb 27, 2024

Conversation

Lendemor
Copy link
Collaborator

since telemetry.send rely on .web/reflex.json folder existing, send the event after the creation of the folder .web.

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@picklelo
Copy link
Contributor

Can we add some unit tests, either here or in a follow up, that actually tries to init the app and verifies the correct event is trying to send

@Lendemor Lendemor merged commit 467fb79 into main Feb 27, 2024
45 checks passed
benedikt-bartscher pushed a commit to benedikt-bartscher/reflex that referenced this pull request Feb 27, 2024
Yummy-Yums pushed a commit to Yummy-Yums/reflex-codebase that referenced this pull request Feb 28, 2024
@masenf masenf deleted the lendemor/fix_missing_telemetry branch February 29, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants