[REF-1994] ThemePanel: clear chakra-ui-color-mode key when using theme panel #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e panel The ThemePanel fights with the ThemeProvider when the user color preference key differs from the `appearance` prop specified in the theme. To avoid issues when using the ThemePanel (in development), clear out the user color preference before loading the page and before unloading the page (to ensure it does not freeze on reload). Clearing the user preference isn't ideal production behavior, but typically the ThemePanel is only used during development for trying out different styles, and having it not freeze the app is better dev behavior. Fix #2650
Lendemor
approved these changes
Mar 6, 2024
mahrz24
pushed a commit
to mahrz24/reflex
that referenced
this pull request
Mar 12, 2024
…e panel (reflex-dev#2799) The ThemePanel fights with the ThemeProvider when the user color preference key differs from the `appearance` prop specified in the theme. To avoid issues when using the ThemePanel (in development), clear out the user color preference before loading the page and before unloading the page (to ensure it does not freeze on reload). Clearing the user preference isn't ideal production behavior, but typically the ThemePanel is only used during development for trying out different styles, and having it not freeze the app is better dev behavior. Fix reflex-dev#2650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ThemePanel fights with the ThemeProvider when the user color preference key differs from the
appearanceprop specified in the theme. To avoid issues when using the ThemePanel (in development), clear out the user color preference before loading the page and before unloading the page (to ensure it does not freeze on reload).Clearing the user preference isn't ideal production behavior, but typically the ThemePanel is only used during development for trying out different styles, and having it not freeze the app is better dev behavior.
Fix #2650