improve event handler state references #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
approved these changes
Mar 11, 2024
picklelo
approved these changes
Mar 11, 2024
| @@ -147,6 +147,10 @@ class EventHandler(EventActionsMixin): | |||
| # The function to call in response to the event. | |||
| fn: Any | |||
|
|
|||
| # The full name of the state class this event handler is attached to. | |||
| # Emtpy string means this event handler is a server side event. | |||
| # Get the state and the function name. | ||
| state_name, name = parts[-2:] | ||
| # Get the state full name | ||
| state_full_name = handler.state_full_name |
mahrz24
pushed a commit
to mahrz24/reflex
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues with event handlers inherited from mixins across modules.
Should also fix potential issues with event handlers and States with the same name in the same module.
In general, this should be a much safer way to format event handlers.