added feature to automatically change port

[wassafshahzad]

All Submissions:

• Have you followed the guidelines stated in CONTRIBUTING.md file?
• Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

New Feature Submission:

• Does your submission pass the tests?
• Have you linted your code locally prior to submission?

Changes To Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Description

Added feature to automatically change port if currently one is used.

Linked Issue

Closes #2857

[srikary12]

I've implemented something similar, but added just auto select functionality after 5 sec instead of by default. You can find the changes here https://github.com/srikary12/reflex-dev

[wassafshahzad]

I've implemented something similar, but added just auto select functionality after 5 sec instead of by default. You can find the changes here https://github.com/srikary12/reflex-dev
@srikary12
Are you shadowing the repo ? if not you should first have the issue assigned to your self before starting and then create a pull request. Other then that I have taken a look at your changes. You are using sockets to check if the port is connected or not, which is not needed since we already have a function called is_process_on_port which informs us if the port is already occupied.

I do like you idea of informing the user before auto selecting the ports but I believe it would be better to have a property in the config something like "auto_select_port: Bool". Since asking the user change_or_terminate_port is a bit redundant in most case as the user can just manually enter a port.
Still good effort.

[masenf]

lgtm

[masenf]

i think we should print an info message here, similar to the one that was removed

            console.info(
                f"The {_type} will run on port [bold underline]{new_port}[/bold underline]."
            )

[wassafshahzad]

Sure will do

[wassafshahzad]

@masenf Done

[picklelo]

Works great for me, this is a sweet improvement!