Handle quote marks ' " in PR titles in benchmark CI #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
requested changes
Mar 19, 2024
.github/workflows/benchmarks.yml
Outdated
| --python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}" | ||
| --benchmark-json "${{ env.OUTPUT_FILE }}" --pr-title "${{ github.event.pull_request.title }}" | ||
| run: | | ||
| escaped_pr_title=$(echo ${{ github.event.pull_request.title }} | sed 's/"/\\"/g') |
There was a problem hiding this comment.
i think we should use single quotes to avoid shell expansion in PR titles... like if i called my pr Cool new trick $(rm -rf /)... that might not be great for the runner
There was a problem hiding this comment.
Not sure what you had in mind with no variable expansion if we were to keep processing the env and passing it around, don't think I figured out a way. But of course we don't have to deal with that, I've uploaded a version that runs
martinxu9
changed the title
masenf
approved these changes
Mar 20, 2024
|
We had an issue in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.