New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF-2168] Add share options to custom component commands #2883
Conversation
Co-authored-by: Masen Furer <m_github@0x26.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the workflow with my image-zoom app and it seemed to work well. I see it entered in the dev database.
Will wait for masen for final approval
@@ -62,6 +62,7 @@ build = "^1.0.3" | |||
setuptools = "^69.1.1" | |||
httpx = ">=0.25.1" | |||
twine = ">=4.0.0" | |||
tomlkit = "^0.12.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a new dependency or already included by one of the packages? Is there a reason for tomlkit rather than the base toml library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tomllib was introduced in 3.11 and it intentionally only includes read/parse. There's no write.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tomllib was introduced in 3.11 and it intentionally only includes read/parse. There's no write.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like the toml parsing much better. nice
i wasn't able to actually test it with my new library yet, due to deploy issues. but the code looks good.
I'll try to invite the whole team to share and seed our db for the gallery |
Summary
share
flag for thepublish
command. By default after a successful publish, the command ask the user if they want to share information such as demo app link. This information goes to Reflex backend services.share
command so the same share logic can happen independent of the publish.Tests
How to test
reflex component share
(it also works when not at the top level of the project, user will be prompted to enter name)customcomponent
table)