Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic for removing the 'None' property along with its corresponding test cases #2969

Merged
merged 2 commits into from Apr 2, 2024

Conversation

AmanSal1
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

New Feature Submission:

  • Does your submission pass the tests?
  • [X Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

Logic for removing the 'None' property 

b. Describe your changes.
 This commit fixes the removal of none props while creating the components  with its corresponding test cases

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).
 Fixes: #2932 

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, change looks good to me! We just need to update some of the older unit tests that raised errors on None, can merge once the tests are passing.

@AmanSal1
Copy link
Contributor Author

AmanSal1 commented Apr 2, 2024

@picklelo Okay so like I don't have to do anything right ? Additionally Can you assign me some more good first issue ?

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@picklelo i updated from main and removed the bad test case so we pass unit tests. I think we're good to go here now.

@picklelo picklelo merged commit 0e221f0 into reflex-dev:main Apr 2, 2024
46 checks passed
@AmanSal1 AmanSal1 deleted the None-prop-removal branch April 3, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants