do not clear all decorated pages during AppHarness tests #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedikt-bartscher
force-pushed
the
harness-decorated-pages
branch
from
e38c828
to
7a3a8b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates issues with multiple AppHarness instances running against the same app.
AppHarness currently clears the global scoped
DECORATED_PAGESbefore starting the app. But reflex only reloads the "root" app module, reloading is not recursive. If you import a module with decorated pages (@rx.page) those pages are not applied after the first AppHarness instance is done.This PR tries to "teardown" the changes during the test, similar to #2916