Use Fallback command on all platforms #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lendemor
requested changes
Apr 17, 2024
| @@ -824,11 +824,15 @@ def install_frontend_packages(packages: set[str], config: Config): | |||
| # unsupported archs will use npm anyway. so we dont have to run npm twice | |||
| fallback_command = ( | |||
| get_package_manager() | |||
| if constants.IS_WINDOWS and constants.IS_WINDOWS_BUN_SUPPORTED_MACHINE | |||
| if not constants.IS_WINDOWS | |||
There was a problem hiding this comment.
Shouldn't the fallback always be npm regardless of OS based on what we discussed? Why is there a case where it's still None ?
There was a problem hiding this comment.
For arm and 32bit machines, get_install_package_manager will return with npm as the primary command since bun is not supported on these. Fallback needs to be None in these cases so npm command is not ran twice
masenf
requested changes
Apr 18, 2024
masenf
approved these changes
Apr 18, 2024
| else None | ||
| ) | ||
| processes.run_process_with_fallback( | ||
| [get_install_package_manager(), "install", "--loglevel", "silly"], | ||
| [get_install_package_manager(), "install"], # type: ignore |
There was a problem hiding this comment.
#type: ignore is a bit suspect here, but not blocking
Lendemor
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback command(
npm) when installing packages should be used on all platforms.Also the
--loglevelflag is used only for npm when installing packages. Bun already runs in debug mode by default and the--loglevelflag has no effect