Clean up config and app API #3197
Merged
+177
−327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lendemor
reviewed
Apr 30, 2024
reflex/app.pyi
Outdated
There was a problem hiding this comment.
Shouldn't there be more changes in this file with how many functions have been renamed in app.py ?
There was a problem hiding this comment.
I removed the app.pyi completely now
masenf
reviewed
Apr 30, 2024
masenf
reviewed
May 2, 2024
Co-authored-by: Masen Furer <m_github@0x26.net>
Co-authored-by: Masen Furer <m_github@0x26.net>
masenf
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin moving things to private methods when we don't want to expose them, and removing things that were deprecated. This is with the goal of getting our API reference to be higher quality.