[REF-3009] type transforming serializers #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedikt-bartscher
force-pushed
the
smart-serialization
branch
from
b50b3d4
to
752e8b9
Compare
benedikt-bartscher
changed the title
1 task
|
Instead of returning a tuple with the serialized type we could also add a kwarg to the @serialize(to=str)
def serialize_datetime(dt: datetime):
return str(dt) |
Serializers can also return a tuple of `(serialized_value, type)`, if both ways are specified, then the returned value MUST match the `to` parameter. When initializing a new rx.Var, if `_var_is_string` is not specified and the serializer returns a `str` type, then mark `_var_is_string=True` to indicate that the Var should be treated like a string literal. Include datetime, color, types, and paths as "serializing to str" type. Avoid other changes at this point to reduce fallout from this change: Notably, the `serialize_str` function does NOT cast to `str`, which would cause existing code to treat all Var initialized with a str as a str literal even though this was NOT the default before. Update test cases to accomodate these changes.
In the future, we will treat strings as string literals in the JS code. To get a Var that is not treated like a string, pass _var_is_string=False. This will allow our serializers to automatically identify cast string literals with less special cases (and the special cases need to be explicitly identified).
masenf
changed the title
There was a problem hiding this comment.
@masenf your changes look good to me, thank you for jumping in!
I am thinking about dropping the tuple return in favor of the new to kwarg. If I am not missing any advantages of the tuple return, I think it would be better to have one way to do things.
The tuple approach would allow dynamic serialization types (type based on input value), but we can't use them in the frontend, so I see no real benefit.
Simplify the logic; instead of making a wrapper function that returns a tuple, just save the type conversions in a separate global.
masenf
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.