Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip connection toaster #3242

Merged
merged 14 commits into from
May 17, 2024
Merged

wip connection toaster #3242

merged 14 commits into from
May 17, 2024

Commits on May 7, 2024

  1. wip connection toaster

    Lendemor committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d61f861 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    a2136b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9275647 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. wip update banner

    Lendemor committed May 15, 2024
    Configuration menu
    Copy the full SHA
    11caa70 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e5c4cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    82e7155 View commit details
    Browse the repository at this point in the history
  4. clean up PR

    Lendemor committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6306a61 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. fix for 3.8

    Lendemor committed May 16, 2024
    Configuration menu
    Copy the full SHA
    56bb19c View commit details
    Browse the repository at this point in the history
  2. update pyi

    Lendemor committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6a245a0 View commit details
    Browse the repository at this point in the history
  3. ConnectionToaster tweaks

    * Use `has_too_many_connection_errors` to avoid showing the banner immediately
    * Increase toast duration to avoid frequent, distracting flashing of the toast
    * Automatically dismiss the toast when the connection comes back up
    * Include `close_button` for user to dismiss the toast
    * If the user dismisses the toast, do not show it again until the connection comes back and drops again
    * Use `connection_error` var instead of a custom util_hook to get the message
    masenf committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c8ac3f4 View commit details
    Browse the repository at this point in the history
  4. ConnectionPulser: hide behind toast

    * Hide the connection pulser behind the toast (33x33)
    * Add a title (tooltip) that shows the connection error
    masenf committed May 16, 2024
    Configuration menu
    Copy the full SHA
    40f69cb View commit details
    Browse the repository at this point in the history
  5. Re-add connection pulser to default overlay_component

    If the user dismisses the toast, we still want to indicate that the backend is
    actually down.
    masenf committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f781e24 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    adb0c35 View commit details
    Browse the repository at this point in the history
  7. Fix pre-commit issue from main

    masenf committed May 16, 2024
    Configuration menu
    Copy the full SHA
    fe2d2fc View commit details
    Browse the repository at this point in the history