Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReconnectingWebSocket instead of vanilla WebSocket #348

Merged
merged 4 commits into from Jan 26, 2023

Conversation

thavocado
Copy link
Contributor

Currently Pynecone doesn't handle websocket onclose events. Using reconnecting-websocket handles such events automatically.

Note that this does not 100% solve the issues which arise on mobile devices, especially iPhones which aggressively control network connection to preserve battery.

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding

@picklelo picklelo merged commit a4ac297 into reflex-dev:main Jan 26, 2023
ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants