Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rx.Var._replace raise TypeError on invalid kwargs #3625

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Jishnu-Nandhiath
Copy link
Contributor

@Jishnu-Nandhiath Jishnu-Nandhiath commented Jul 4, 2024

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

rx.Var._replace will raise TypeError, if any invalid kwargs are passed to the function, apart from the Var class attributes.

closes #3531

@benedikt-bartscher
Copy link
Contributor

@Jishnu-Nandhiath i think reflex.vars.ComputedVar needs the same error handling

@Jishnu-Nandhiath
Copy link
Contributor Author

@benedikt-bartscher yeah, seems like it. Will add if necessary

@Lendemor
Copy link
Collaborator

Lendemor commented Jul 5, 2024

@benedikt-bartscher yeah, seems like it. Will add if necessary

I think you can add it yeah.

Also you'll need to run pre-commit to pass the one CI check that is failing.

@Jishnu-Nandhiath
Copy link
Contributor Author

Ok. I'll add it then. Yeah, forgot to pre-commit last time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REF-3160] [VarOps] It is way too easy to pass incorrect kwargs to rx.Var._replace
3 participants