Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error message for invalid event handler signature #363

Merged
merged 1 commit into from
Jan 28, 2023
Merged

error message for invalid event handler signature #363

merged 1 commit into from
Jan 28, 2023

Conversation

qu3vipon
Copy link
Contributor

@qu3vipon qu3vipon commented Jan 27, 2023 •
edited
Loading

Resolve: #349

Couldn't get enough context inside this util function, so just let a developer know which function used is invalid.

It prints out,

TypeError: Event handler has an invalid signature, needed a method with a parameter, got fn=<function State.change_text at 0x113131670>.

@qu3vipon qu3vipon marked this pull request as draft January 27, 2023 17:42
@qu3vipon qu3vipon force-pushed the feat/event-handler-type-error branch from 4e58d14 to e4a00ce Compare January 27, 2023 18:09
@qu3vipon qu3vipon marked this pull request as ready for review January 27, 2023 18:09
@qu3vipon qu3vipon force-pushed the feat/event-handler-type-error branch from e4a00ce to bad3375 Compare January 27, 2023 18:13
picklelo
picklelo approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for the explicit message

@picklelo picklelo merged commit f22c67e into reflex-dev:main Jan 28, 2023
@qu3vipon qu3vipon deleted the feat/event-handler-type-error branch January 28, 2023 04:59
ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
@qu3vipon @ACucos1
Type check event handler signature (reflex-dev#363)
9d6e882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0b2g1t r0b2g1t r0b2g1t approved these changes

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw better error message for invalid event handler signature
3 participants
@qu3vipon @r0b2g1t @picklelo