Check if curl and unzip are installed, fix #383 #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HellAmbro
changed the title
HellAmbro
changed the title
picklelo
requested changes
Jan 29, 2023
| # Check if curl is installed | ||
| curl_path = which("curl") | ||
| if curl_path is None: | ||
| raise FileNotFoundError("Pynecone requires curl to be installed.") |
There was a problem hiding this comment.
We need to add this to the docstring:
"""Install bun onto the user's system.
Raises:
FileNotFoundError: If the required packages are not installed.
"""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @brianmcconnel noted, Pynecone initialization may fail if curl and unzip are not installed.
Checks whether they are installed, if not the user is notified with a proper message.