Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Pynecone Container Image Build #387

Merged
merged 2 commits into from Jan 30, 2023

Conversation

r0b2g1t
Copy link
Contributor

@r0b2g1t r0b2g1t commented Jan 29, 2023

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

After these steps, you're ready to open a pull request.

After my support for the PR #361 and I decided to create an updated Dockerfile with a more precise description and optimized container images. Including all findings from the other PR additionally included is a documentation. With the aim that every Pynecone user can build his own container image of his service.

The container image includes multi stage Dockerfile which builds an optimized sized image. I have also created a readme with all the necessary steps to perform the build itself.

Copy link
Contributor

@Alek99 Alek99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

@Alek99 Alek99 merged commit 7fefbcd into reflex-dev:main Jan 30, 2023
ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants